Proposed solution to #466, adding support for admin pointers #479
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
April 28, 2014 20:18
…allow extensions to hook into it.
… pointers through this class.
| if ( options.position && options.position.defer_loading ) | ||
| $(window).bind( 'load.wp-pointers', setup ); | ||
| else | ||
| $(document).ready( setup ); |
There was a problem hiding this comment.
Should use brackets of the if/else
There was a problem hiding this comment.
|
Cue the nominal warning that Pointers isn't meant as an external API, so it may change without warnings in future core releases. But then, WP_List_Table isn't either, so ymmv. :) |
|
@georgestephanis true, though since we do most of our development on |
|
Yup, hence it just being nominal. :) |
added 2 commits
April 30, 2014 09:41
…ed escaping to JSON encoding.
| 'WP_Stream_Pointers' => array( | ||
| 'index.php' => 'wpstream143_extensions', | ||
| 'toplevel_page_wp_stream' => 'wpstream143_extensions', | ||
| 'stream_page_wp_stream_settings' => 'wpstream143_extensions', |
There was a problem hiding this comment.
@Japh Would be good to reference the constant for this instead of hard coding it:
'stream_page_' . WP_Stream_Admin::SETTINGS_PAGE_SLUG
|
@Japh Nicely done. |
frankiejarrett
added a commit
that referenced
this pull request
May 2, 2014
Proposed solution to #466, adding support for admin pointers
|
Aw yeah! Thanks :D |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'd like feedback on this so far, as my first contribution to Stream :)
Resolves #466