-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Proposed solution to #466, adding support for admin pointers #479
Conversation
…allow extensions to hook into it.
… pointers through this class.
if ( options.position && options.position.defer_loading ) | ||
$(window).bind( 'load.wp-pointers', setup ); | ||
else | ||
$(document).ready( setup ); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should use brackets of the if/else
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cue the nominal warning that Pointers isn't meant as an external API, so it may change without warnings in future core releases. But then, WP_List_Table isn't either, so ymmv. :) |
@georgestephanis true, though since we do most of our development on |
Yup, hence it just being nominal. :) |
…ed escaping to JSON encoding.
'WP_Stream_Pointers' => array( | ||
'index.php' => 'wpstream143_extensions', | ||
'toplevel_page_wp_stream' => 'wpstream143_extensions', | ||
'stream_page_wp_stream_settings' => 'wpstream143_extensions', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Japh Would be good to reference the constant for this instead of hard coding it:
'stream_page_' . WP_Stream_Admin::SETTINGS_PAGE_SLUG
@Japh Nicely done. |
Proposed solution to #466, adding support for admin pointers
Aw yeah! Thanks :D |
I'd like feedback on this so far, as my first contribution to Stream :)
Resolves #466